Skip to content

feat: improve the URL validation and error handling in 'parseDeeplink' Method#9236

Merged
christopherferreira9 merged 3 commits intomainfrom
feat_validate-broken-deeplinks
Apr 16, 2024
Merged

feat: improve the URL validation and error handling in 'parseDeeplink' Method#9236
christopherferreira9 merged 3 commits intomainfrom
feat_validate-broken-deeplinks

Conversation

@omridan159
Copy link
Copy Markdown
Contributor

@omridan159 omridan159 commented Apr 15, 2024 •
edited
Loading

Description

*This is a fix to this Issue: https://github.com/MetaMask/mobile-planning/issues/1520

This pull request enhances the parseDeeplink method by adding robust URL validation and error handling.
Key improvements include:

  • URL Validation: Ensures only correctly formatted URLs are processed to prevent errors during deep linking.
  • Error Handling: Captures exceptions with updated error handling, and alerting users to invalid URLs via a react-native alert.

These updates aim to improve the security and user experience by preventing the processing of malformed URLs and providing immediate feedback on errors.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Available in this Issue:
https://github.com/MetaMask/mobile-planning/issues/1520

After

Screen.Recording.2024-04-15.at.11.14.37.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@omridan159 omridan159 requested a review from a team as a code owner April 15, 2024 10:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@omridan159 omridan159 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk-deprecated DEPRECATED: please use "team-wallet-integrations" instead labels Apr 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3e149cc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c11d02b2-7825-4509-a47d-f3da347d18d1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 15, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@christopherferreira9 christopherferreira9 added Run Smoke E2E QA Passed QA testing has been completed and passed and removed Run Smoke E2E QA in Progress QA has started on the feature. labels Apr 16, 2024
@christopherferreira9
Copy link
Copy Markdown
Contributor

christopherferreira9 commented Apr 16, 2024

All good in QA.
Tested on both iOS and Android:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7ba1ec1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b1ee3a3-f960-4b08-a915-3200f83a27df

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@christopherferreira9 christopherferreira9 merged commit 7d02a47 into main Apr 16, 2024
@christopherferreira9 christopherferreira9 deleted the feat_validate-broken-deeplinks branch April 16, 2024 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abretonc7s abretonc7s abretonc7s approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-sdk-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@omridan159 @christopherferreira9 @abretonc7s @metamaskbot @witmicko