Skip to content

fix(deps): Move @metamask/react-native-animated-fox from git to npm#9384

Merged
legobeat merged 1 commit intomainfrom
deps-fix-react-native-fox
Apr 24, 2024
Merged

fix(deps): Move @metamask/react-native-animated-fox from git to npm#9384
legobeat merged 1 commit intomainfrom
deps-fix-react-native-fox

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Apr 23, 2024 •
edited
Loading

Description

The referenced version of dependency react-native-animated-fox has been published on NPM registry as @metamask/react-native-animated-fox.

This replaces the git+https://github.com reference with the published package.

Related issues

Manual testing steps

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Apr 23, 2024
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 23, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/react-native-animated-fox@2.1.0 None 0 31.9 kB lgbot

🚮 Removed packages: npm/react-native-animated-fox@2.0.1

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 23, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/react-native-animated-fox@2.1.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7cbda51
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9869ec27-4edf-42dd-a7ec-cdc9875dabcd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Apr 23, 2024 

@SocketSecurity ignore npm/@metamask/react-native-animated-fox@2.1.0

new author ok

@legobeat legobeat marked this pull request as ready for review April 23, 2024 21:28
@legobeat legobeat requested a review from a team as a code owner April 23, 2024 21:28
@legobeat legobeat force-pushed the deps-fix-react-native-fox branch from 7cbda51 to fa7609f Compare April 23, 2024 21:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: fa7609f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/030fd9cb-18b3-456f-9b0e-f47e2969370f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Apr 23, 2024
Closed
8 tasks
@legobeat legobeat force-pushed the deps-fix-react-native-fox branch from fa7609f to 192493b Compare April 24, 2024 00:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 192493b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2ac6b5e2-7d22-4523-bc79-f34c6a256900

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-fix-react-native-fox branch from 192493b to 0074e4e Compare April 24, 2024 03:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0074e4e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33fc314a-d7f5-473c-b38c-ed98af12077c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-fix-react-native-fox branch from 0074e4e to dfda23b Compare April 24, 2024 05:05
@legobeat legobeat force-pushed the deps-fix-react-native-fox branch from dfda23b to 62fd18a Compare April 24, 2024 06:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 62fd18a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/192bdde6-7e02-483e-84b7-e1ea12ed5a26

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini previously approved these changes Apr 24, 2024
View reviewed changes
@legobeat legobeat force-pushed the deps-fix-react-native-fox branch 2 times, most recently from c3f3199 to 894ff5a Compare April 24, 2024 20:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 894ff5a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/78515109-3f44-47a5-8308-61b587033599

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-fix-react-native-fox branch from 894ff5a to 76593d1 Compare April 24, 2024 22:18
@legobeat legobeat requested a review from a team April 24, 2024 22:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 76593d1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e724487-8c0f-425d-862f-4153055a2fab

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Apr 24, 2024
Merged
13 tasks
@legobeat legobeat force-pushed the deps-fix-react-native-fox branch from 76593d1 to 240a1ac Compare April 24, 2024 22:41
Gudahtt
Gudahtt approved these changes Apr 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 24, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 240a1ac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/35d0a394-117b-4387-b977-bb692b403359

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat merged commit 1daa17c into main Apr 24, 2024
@legobeat legobeat deleted the deps-fix-react-native-fox branch April 24, 2024 23:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@tommasini tommasini tommasini left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @Gudahtt @tommasini @metamaskbot