Conversation
945ee0c to
c99f1ec
Compare
4d8248e to
db7a223
Compare
db7a223 to
dd54ef6
Compare
dd54ef6 to
8792c80
Compare
package.json
Outdated
| "vm-browserify": "1.1.2", | ||
| "zxcvbn": "4.4.2" | ||
| "zxcvbn": "4.4.2", | ||
| "react-native-tcp": "^3.2.1" |
There was a problem hiding this comment.
Would like to understand how this is getting re-added before we merge this. We don't want two copies of this
There was a problem hiding this comment.
after taking a closer look at this one the PR (aprock/react-native-tcp#11/head) had actually been merged. So, I think we're fine to simply use latest (4.0.0)
There was a problem hiding this comment.
Actually wait a minute, it doesn't look like that change is a part of v4.0.0. The changes in that PR diff aren't in the commit tagged as v4, it's not in the commit history either.
There was a problem hiding this comment.
ah! nice catch...
idk why I assumed if it was merged it was published 🙃...
I'll continue looking at if we can use the patch approach... alternatively, maybe we can bug the author to publish a new version?
There was a problem hiding this comment.
In order to unblock this PR and get the more obvious ones through - could we omit the react-native-tcp change here?
There was a problem hiding this comment.
ya. closing this for now since it's stale (the work) and stale (the context in my brain)
also, apparently the mobile team is in the process of upgrading react native and that will affect all of this... so probably better to wait and do the work interactively as you mentioned
cc @Gudahtt
previously we were using git for some deps... this was blocking #5147
it's also a security concern in the cases where we weren't pinning to a SHA
I worked with @Gudahtt to fork all the deps and publish them under the
@metamask/namespace.This PR makes use of the newly published modules.
I'm opening this as a separate PR so #5147 isn't so heavy handed.