feat: Improve localization workflow such that it allows for branch/PR focused translation#8565
Merged
feat: Improve localization workflow such that it allows for branch/PR focused translation#8565
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8565 +/- ##
==========================================
+ Coverage 40.90% 45.50% +4.60%
==========================================
Files 1245 1275 +30
Lines 30150 31202 +1052
Branches 2895 3184 +289
==========================================
+ Hits 12333 14199 +1866
+ Misses 17114 16163 -951
- Partials 703 840 +137 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
7897cdb to
7c86692
Compare
- This allows for branch/PR focused translations
7c86692 to
dc227bd
Compare
mcmire
reviewed
Mar 21, 2024
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This allows for branch/PR focused translations
Description
Currently, translation only happens once changes to the en.json file are merged to main. These changes could include new keys being added or changes to english text. What this means is that there is no way currently to require that translations be in place before the feature goes live. It could make it through translation before being released but there is currently no way to require that we wait for translations.
Related issues
Fixes: 8564
Manual testing steps - To be done after merge and with Desi
Use case 1 (feature branch requires translation):
Use Case 2 (main branch translations):
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist