Skip to content

test: 8735 research appium upgrading app version#8896

Merged
SamuelSalas merged 9 commits intomainfrom
test/8735-research-appium-upgrading-app-version
Apr 16, 2024
Merged

test: 8735 research appium upgrading app version#8896
SamuelSalas merged 9 commits intomainfrom
test/8735-research-appium-upgrading-app-version

Conversation

@SamuelSalas
Copy link
Copy Markdown
Contributor

@SamuelSalas SamuelSalas commented Mar 11, 2024 •
edited
Loading

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d01b2c5b-7295-4aba-bd80-9abb4c7939ae

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas self-assigned this Mar 11, 2024
@SamuelSalas SamuelSalas requested a review from a team as a code owner March 11, 2024 21:29
@SamuelSalas SamuelSalas linked an issue Mar 11, 2024 that may be closed by this pull request
Research: E2E flow that covers upgrading the application between release versions. #8735
Closed
9 tasks
@SamuelSalas SamuelSalas marked this pull request as draft March 11, 2024 21:29
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.35%. Comparing base (3fe4f51) to head (1f61431).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8896   +/-   ##
=======================================
  Coverage   45.35%   45.35%           
=======================================
  Files        1272     1272           
  Lines       31247    31247           
  Branches     3189     3189           
=======================================
  Hits        14171    14171           
  Misses      16234    16234           
  Partials      842      842

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelSalas SamuelSalas mentioned this pull request Mar 11, 2024
Closed
9 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 20, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@SamuelSalas SamuelSalas marked this pull request as ready for review April 12, 2024 19:04
@SamuelSalas SamuelSalas requested a review from a team April 12, 2024 19:04
@SamuelSalas SamuelSalas added the team-mobile-platform Mobile Platform team label Apr 12, 2024
@Cal-L
Copy link
Copy Markdown
Contributor

Cal-L commented Apr 16, 2024 •
edited
Loading

release_e2e_pipeline build - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/422e63f6-c895-41ad-be1d-d0c6635b2d55

Edit: Upgrade test succeeded. Other E2E test due to flakiness

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 16, 2024
Cal-L
Cal-L approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelSalas SamuelSalas added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 16, 2024
@SamuelSalas SamuelSalas merged commit 66821fd into main Apr 16, 2024
@SamuelSalas SamuelSalas deleted the test/8735-research-appium-upgrading-app-version branch April 16, 2024 11:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 16, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

@SamuelSalas SamuelSalas

Labels

QA Passed QA testing has been completed and passed release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Research: E2E flow that covers upgrading the application between release versions.

4 participants

@SamuelSalas @codecov-commenter @Cal-L @metamaskbot