Skip to content

ci: Add Bitrise workflow to test android app upgrade using appium on Browserstack#9002

Merged
Cal-L merged 54 commits intotest/8735-research-appium-upgrading-app-versionfrom
ci/8927-bitrise-app-upgrade-e2e
Apr 12, 2024
Merged

ci: Add Bitrise workflow to test android app upgrade using appium on Browserstack#9002
Cal-L merged 54 commits intotest/8735-research-appium-upgrading-app-versionfrom
ci/8927-bitrise-app-upgrade-e2e

Conversation

@Cal-L
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L commented Mar 19, 2024 •
edited
Loading

Description

The following changes has been made to bitrise.yml

run_android_appium_test - New workflow for testing Android appium tests for QA builds. This defaults to run performance tests unless BROWSERSTACK_TAG_EXPRESSION is specified. Run this instead of build_android_qa if start times are needed.
run_tag_upgrade_android - New workflow for running app upgrade e2e test on appium for Android QA builds. Uses run_android_appium_test under the hood and sets BROWSERSTACK_TAG_EXPRESSION
build_android_qa - No longer runs Android performance tests
release_builds_to_store_pipeline - Added stage to create QA build alongside RCs. The QA build is later referenced in future run_tag_upgrade_android workflows
release_e2e_pipeline - Added run_tag_upgrade_android to run app upgrade for Android QA builds

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 19, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (test/8735-research-appium-upgrading-app-version@1f61431). Click here to learn what that means.

❗ Current head 9609dfb differs from pull request most recent head d9d0211. Consider uploading reports for the commit d9d0211 to get more accurate results

Additional details and impacted files 
@@                                Coverage Diff                                 @@
##             test/8735-research-appium-upgrading-app-version    #9002   +/-   ##
==================================================================================
  Coverage                                                   ?   45.58%           
==================================================================================
  Files                                                      ?     1276           
  Lines                                                      ?    31302           
  Branches                                                   ?     3202           
==================================================================================
  Hits                                                       ?    14270           
  Misses                                                     ?    16186           
  Partials                                                   ?      846

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cal-L Cal-L force-pushed the ci/8927-bitrise-app-upgrade-e2e branch from 5ce87a1 to 4bbbbac Compare March 24, 2024 07:44
@socket-security
Copy link
Copy Markdown

socket-security bot commented Mar 24, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@Cal-L Cal-L force-pushed the ci/8927-bitrise-app-upgrade-e2e branch from 4bbbbac to b182374 Compare March 24, 2024 07:51
@Cal-L
Copy link
Copy Markdown
Contributor Author

Cal-L commented Mar 29, 2024

run_e2e_pipeline showing upgrade test success - https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8d8b90d-20e8-4244-9452-b440c66b208d. The failures on other tests are not related to this branch

@Cal-L Cal-L added team-mobile-platform Mobile Platform team No E2E Smoke Needed No QA Needed Apply this label when your PR does not need any QA effort. and removed No E2E Smoke Needed labels Mar 29, 2024
@Cal-L Cal-L marked this pull request as ready for review March 29, 2024 17:22
@Cal-L Cal-L requested a review from a team March 29, 2024 17:22
@Cal-L Cal-L requested a review from a team as a code owner March 29, 2024 17:22
@Cal-L Cal-L changed the title ci: Add workflow to test android app upgrade using appium on Browserstack ci: Add Bitrise workflow to test android app upgrade using appium on Browserstack Mar 29, 2024
@Cal-L Cal-L added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 29, 2024
@Cal-L
Merge branch 'test/8735-research-appium-upgrading-app-version' of git…
d9d0211 
…hub.com:MetaMask/metamask-mobile into ci/8927-bitrise-app-upgrade-e2e
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

SamuelSalas
SamuelSalas reviewed Mar 30, 2024
View reviewed changes
@SamuelSalas SamuelSalas self-requested a review April 11, 2024 01:40
SamuelSalas
SamuelSalas approved these changes Apr 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 84c7d7c into test/8735-research-appium-upgrading-app-version Apr 12, 2024
@Cal-L Cal-L deleted the ci/8927-bitrise-app-upgrade-e2e branch April 12, 2024 06:26
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@github-actions github-actions bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox left review comments

+1 more reviewer

@SamuelSalas SamuelSalas SamuelSalas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cal-L @codecov-commenter @chrisleewilcox @SamuelSalas