Skip to content

feat: Update the Palm logo with a new one#9227

Merged
EtherWizard33 merged 2 commits intomainfrom
feat-9198-update-the-palm-icon-to-new-one
Apr 16, 2024
Merged

feat: Update the Palm logo with a new one#9227
EtherWizard33 merged 2 commits intomainfrom
feat-9198-update-the-palm-icon-to-new-one

Conversation

@EtherWizard33
Copy link
Copy Markdown
Contributor

@EtherWizard33 EtherWizard33 commented Apr 12, 2024 •
edited
Loading

Description

The palm logo needed updating, it was confirmed that the logo used in the extension was the correct one.

Related issues

Fixes:

Manual testing steps

In the header, select the network to bring up the change network bottom list, click on Add network, the Palm logo should be visible next to the Palm network (if the network is part of the networks that can be added).

Screenshots/Recordings

With old logo The new logo With new logo
Image 1 Image 2 Image 3

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 added team-mobile-ux Mobile UX team team-core-extension-ux Core Extension UX team Run Smoke E2E needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed team-mobile-ux Mobile UX team labels Apr 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1cd6971
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3da268ab-ef68-4318-8d04-8df0c620a150

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33
Copy link
Copy Markdown
Contributor Author

EtherWizard33 commented Apr 15, 2024

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 15, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@EtherWizard33 EtherWizard33 added Run Smoke E2E and removed Run Smoke E2E INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8781220
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d73e7c33-4c2a-4c99-aed6-15d32a5e2f58

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 15, 2024
@EtherWizard33 EtherWizard33 removed INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E labels Apr 15, 2024
@EtherWizard33 EtherWizard33 marked this pull request as ready for review April 16, 2024 11:06
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner April 16, 2024 11:06
@EtherWizard33 EtherWizard33 merged commit b635299 into main Apr 16, 2024
@EtherWizard33 EtherWizard33 deleted the feat-9198-update-the-palm-icon-to-new-one branch April 16, 2024 18:37
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+2 more reviewers

@darkwing darkwing darkwing approved these changes

@frankvonhoven frankvonhoven frankvonhoven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-core-extension-ux Core Extension UX team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@EtherWizard33 @darkwing @NidhiKJha @frankvonhoven @metamaskbot