Merged
Conversation
…napshot [jest-specific-snapshot]: New definition.
…shot [jest-image-snapshot]: New type definitions.
Add whatwg-mimetype definition.
Hackily added toMatch to expect-puppeteer
Jquery countto
…emove lint errors.
Added type definitions for clearbladejs-client, clearbladejs-server, clearbladejs-node
…24821) * added new type definition for npm package strong-error-handler v2.3 * Updated strict null checks to true, tsconfig Per reviewers request, updated tsconfig strictnullchecks true
webvr-api: Make webvr-api consistent with latest lib.es6.d.ts
* Added types for dnssd * Cosmetics, test passed * Removed unused rules
* Add type for react-native-i18n * Fix tests with correct typescript version
* [nock] Add Promise based Nock Back types Documentation: https://github.com/node-nock/nock#nock-back * [nock] Add test for promised nockBack
Present in 2.7 as per docs and code
…22.0 (#24686) * radium: update typings to fit with new default export in radium >= 0.22.0 * radium: replace tabs with spaces * radium: updated radium version number in header comment
Bump version to 8.10 to match current runtime, allow returning result promises in handlers.
* Update three-transformcontrols.d.ts Added missing methods * Update three-core.d.ts Added missing isMesh prop
* add 'Texture' attribute: 'center','rotation' * add 'ShapeBufferGeometry' * Geometry: Move computeLineDistance() to Line * return this
As lru-cache has `V | undefined`, this `get()` function should also mark undefined as possible return type to allow assigning an LRU to `cache`.
* [stripe] Fix typo in `IProductCreationOptions`. The `IProductCreationOptions` interface mistakenly lists `attribute` instead of `attributes` as a property. This does not not match [the API specification for product creation](https://stripe.com/docs/api#create_product), and attempting to actually populate this field results in: `Error: Received unknown parameter: attribute`. Changing this value to `attributes` successfully allows `stripe.products.create()` calls to succeed in populating attributes. * Added `attributes` to tests for product creation.
* [ADD] Wix Detox Types * [FIX] Detox Definiations lint error * [FIX] Lint issues
- Move typings for v3 to the separate v3 folder - Implement typings for v4.2 - Implement tests for typings
* Enhance definition and according tests for heapdump * Add changes to fix the CI
* Declare that `CKEDITOR` has event subscription interface for global events like `"instanceCreated"`. Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR.html#Events * Declare `CKEDITOR.editor.getSelectedHtml` with overloads. Documentation link: https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.editor-method-getSelectedHtml * Declare some arguments as optional Documentation links: * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.event-method-preventDefault * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.range-method-createBookmark2 * https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_dom_node.html#method-getAddress * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.range-method-getCommonAncestor * Fix typings of `createBookmark[s][2]`: * Properly declare methods `createBookmarks[2]` instead of `createBookmark[2]` on `CKEDITOR.dom.rangeList`. Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_dom_rangeList.html#method-createBookmarks * Use return type of `bookmark[]` for "intrusive bookmarks" everywhere as in `CKEDITOR.dom.range.createBookmark`. * Declare parameters of `CKEDITOR.dom.selection.createBoomarks[2]` as required `Object`'s to follow the documentation. Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_dom_selection.html#method-createBookmarks * Declare method `CKEDITOR.dom.node.remove` mistakenly named `move` in the typings. * Declare `CKEDITOR.dom.range.setEnd{Before,After}` in addition to `setStart{Before,After}`. Documentation links: * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.range-method-setEndAfter * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.range-method-setEndBefore * Declare some `CKEDITOR.tools` Documentation links: * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.tools-method-copy * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.tools-method-isArray * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.tools-method-override * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.tools-method-prototypedCopy * Declare `CKEDITOR.plugins.registered`. Documentation link: https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.resourceManager-property-registered * Declare `CKEDITOR.htmlParser.element.addClass` in addition to `removeClass` and `hasClass`. Documentation link: https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.htmlParser.element-method-addClass * Declare `CKEDITOR.htmlParser.{element,fragment}.forEach`. Documentation links: * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.htmlParser.element-method-forEach * https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.htmlParser.fragment-method-forEach * Coding style: Convert to single quotes and spaces for indentation. * Make `fileName` parameter of `CKEDITOR.plugins.addExternal` optional. Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_plugins.html#method-addExternal * Make `editable` as a class and declare its constructor. Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_editable.html#method-constructor
…HyperCubeContinuousData (#25010) Signed-off-by: Konrad Mattheis <konrad.mattheis@akquinet.de>
* Edited version * Because travis succ * Added friend's suggestions * Fixed * Upgraded typescript version
* Add jsonwebtoken-promisified * Add types/jsonwebtoken-promisified * Remove tslint ignore statements & fix issues
* Add new definitions for toobusy-js * Change import according to the change-request
…rops (#25040) * Grid - add onScrollbarPresenceChange to GridCoreProps * Fix irregular whitespace
* express-winston: relax types on meta object * express-winston: change meta object type to
…24936) * fixed pick and omit type signatures to be more helpful * changed pick to try and pass tests, tsnext still complaining * added CaptJakk to contributors * changed keyof index signatures to just strings * simplified Omit type signature
* Added types for dnssd * Cosmetics, test passed * Removed unused rules * Service entry type added Browser implements EventEmitter * make tslint happy
* Update index.d.ts * Update pg-tests.ts
* Loosen navigator navigationOptions * Fix linter
* [estree] make function declaration id nullable * apply review feedback * [estree] make class declaration id nullable
* Ember: Make `RegistryProxyMixin.register` options optional. * Add tests for register change.
This commit addresses a problem where the following would produce a type
error, even though it was valid code:
```typescript
setCanvasData({left: 23})
```
I have changed the argument type for all of the `setXXX` methods which
accept an object as their argument. In the spec files for cropperjs,
@fengyuanchen uses these objects as partials for setters. So I have
made the type definitions follow that same pattern.
I changed the `cropperjs.CropBoxData` type to act the same way as well.
It looks like it was changed at some point, I am guessing to allow it
to be used as a partial in the `setCropBoxData` method. Since, like all
the other data structures here, it contains all members when you `get`
it, I have made all members required parts of the object and changed
the setter method to accept a partial.
I hope this all makes sense. Basically, I went from the first line below
to the second.
```typescript
setXXXXX(thing: cropperjs.SomeInterface): void
setXXXXX(thing: Partial<cropperjs.SomeInterface>): void
```
Then I changed `cropperjs.CropBoxData` to fit this new system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.