Skip to content

Hackily added toMatch to expect-puppeteer#24751

Merged
paulvanbrenk merged 1 commit intoDefinitelyTyped:masterfrom
JoshuaKGoldberg:expect-puppeteer-match
Apr 6, 2018
Merged

Hackily added toMatch to expect-puppeteer#24751
paulvanbrenk merged 1 commit intoDefinitelyTyped:masterfrom
JoshuaKGoldberg:expect-puppeteer-match

Conversation

@JoshuaKGoldberg
Copy link
Copy Markdown
Collaborator

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

I dislike this solution... but don't see a way around it.

@typescript-bot typescript-bot added the Unowned This PR touches a package that doesn't have any listed owners. label Apr 6, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 6, 2018

@JoshuaKGoldberg Thank you for submitting this PR!

Because this PR doesn't have any code reveiwers, a DefinitelyTyped maintainer will be reviewing it in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@paulvanbrenk paulvanbrenk merged commit 8c8e7f4 into DefinitelyTyped:master Apr 6, 2018
@JoshuaKGoldberg JoshuaKGoldberg deleted the expect-puppeteer-match branch April 6, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unowned This PR touches a package that doesn't have any listed owners.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants