Hackily added toMatch to expect-puppeteer#24751
Merged
paulvanbrenk merged 1 commit intoDefinitelyTyped:masterfrom Apr 6, 2018
JoshuaKGoldberg:expect-puppeteer-match
Merged
Hackily added toMatch to expect-puppeteer#24751paulvanbrenk merged 1 commit intoDefinitelyTyped:masterfrom JoshuaKGoldberg:expect-puppeteer-match
paulvanbrenk merged 1 commit intoDefinitelyTyped:masterfrom
JoshuaKGoldberg:expect-puppeteer-match
Conversation
Contributor
|
@JoshuaKGoldberg Thank you for submitting this PR! Because this PR doesn't have any code reveiwers, a DefinitelyTyped maintainer will be reviewing it in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.I dislike this solution... but don't see a way around it.