Add write-file-atomically types#25064
Add write-file-atomically types#25064RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom Aankhen:add-write-file-atomically
write-file-atomically types#25064Conversation
|
@Aankhen Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
| @@ -0,0 +1,10 @@ | |||
| import * as writeFileAtomically from 'write-file-atomically'; | |||
There was a problem hiding this comment.
Classes and functions cannot be imported using import * as syntax. Please fix either the test or the definition file to use a correct import form.
There was a problem hiding this comment.
I see. Thanks for the link. Strange that neither the lint nor the testing caught it.
Should I be using export default in this case? Or is it reasonable to expect users to say import writeFileAtomically = require("write-file-atomically");?
There was a problem hiding this comment.
Does the module actually provide a default export, or is it a CommonJS module that you could only import through require ?
|
@Aankhen One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
write-file-atomically types.write-file-atomically types
|
🔔 @RyanCavanaugh - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
|
Thanks! |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.