Skip to content

chart.js: add ChartOptions.onHover alias and amend type#24740

Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
dylex:master
Apr 9, 2018
Merged

chart.js: add ChartOptions.onHover alias and amend type#24740
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
dylex:master

Conversation

@dylex
Copy link
Copy Markdown
Contributor

@dylex dylex commented Apr 5, 2018

Present in 2.7 as per docs and code. ChartOptions.onHover and ChartHoverOptions.onHover are equivalent. Also added this type for these function (could be added for others -- not done here -- though different callbacks are called in different contexts).

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

Present in 2.7 as per docs and code
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 5, 2018

@dylex Thank you for submitting this PR!

🔔 @anuti @FabienLavocat @KentarouTakeda @larrybahr @mernen @josefpaij @danmana @guillaume-ro-fr @chicoxyzzy - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@mhegazy mhegazy merged commit 00ca94d into DefinitelyTyped:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants