Added new type definition for npm package strong-error-handler v2.3#24821
Merged
mhegazy merged 2 commits intoDefinitelyTyped:masterfrom Apr 9, 2018
blankstar85:strong-error-handler@2.3
Merged
Added new type definition for npm package strong-error-handler v2.3#24821mhegazy merged 2 commits intoDefinitelyTyped:masterfrom blankstar85:strong-error-handler@2.3
mhegazy merged 2 commits intoDefinitelyTyped:masterfrom
blankstar85:strong-error-handler@2.3
Conversation
Contributor
|
@blankstar85 Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
plantain-00
suggested changes
Apr 9, 2018
| ], | ||
| "noImplicitAny": true, | ||
| "noImplicitThis": true, | ||
| "strictNullChecks": false, |
Contributor
There was a problem hiding this comment.
For new packages, this should be enabled.
Contributor
|
@blankstar85 One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Per reviewers request, updated tsconfig strictnullchecks true
Contributor
Author
|
Updated per your request, Thanks! |
Contributor
|
🔔 @plantain-00 - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
dts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.