Skip to content

Add whatwg-mimetype definition.#24774

Merged
paulvanbrenk merged 1 commit intoDefinitelyTyped:masterfrom
petejohanson:whatwg-mimetype
Apr 6, 2018
Merged

Add whatwg-mimetype definition.#24774
paulvanbrenk merged 1 commit intoDefinitelyTyped:masterfrom
petejohanson:whatwg-mimetype

Conversation

@petejohanson
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them. (Submitted a PR (Add TypeScript definition? jsdom/whatwg-mimetype#11) but the author politely declined)
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 6, 2018

@petejohanson Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@paulvanbrenk paulvanbrenk merged commit a31ee99 into DefinitelyTyped:master Apr 6, 2018
@petejohanson
Copy link
Copy Markdown
Contributor Author

@paulvanbrenk Thanks for merging this so promptly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants