Skip to content

[react-virtualized] Grid - add onScrollbarPresenceChange to GridCoreProps#25040

Merged
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
jacoporicare:react-virtualized/grid
Apr 17, 2018
Merged

[react-virtualized] Grid - add onScrollbarPresenceChange to GridCoreProps#25040
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
jacoporicare:react-virtualized/grid

Conversation

@jacoporicare
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

I've added onScrollbarPresenceChange to GridCoreProps type - this type is also used as base of List props. From the docs of List: "It uses a Grid internally to render the rows and all props are relayed to that inner Grid. That means that List also accepts Grid props in addition to the props shown below."

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018

@jacoporicare Thank you for submitting this PR!

🔔 @kaoDev @guntherjh @wasd171 @szabolcsx @kraenhansen @Stevearzh @mgoszcz2 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Copy Markdown
Contributor

@Stevearzh Stevearzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit 1f555b0 into DefinitelyTyped:master Apr 17, 2018
@jacoporicare jacoporicare deleted the react-virtualized/grid branch April 20, 2018 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants