Add new type definition for toobusy-js#25019
Add new type definition for toobusy-js#25019RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
|
@atd-schubert Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
types/toobusy-js/toobusy-js-tests.ts
Outdated
| @@ -0,0 +1,17 @@ | |||
| import * as toobusy from "toobusy-js"; | |||
There was a problem hiding this comment.
Classes and functions cannot be imported using import * as syntax. Please fix either the test or the definition file to use a correct import form.
|
@atd-schubert One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
|
🔔 @RyanCavanaugh - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
Add new type definition for npm package
toobusy-js.npm test.)npm run lint package-name(ortscif notslint.jsonis present).Adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.Type defintion is based on: https://github.com/STRML/node-toobusy/blob/master/toobusy.js