Skip to content

Add types for dnssd#24760

Merged
mhegazy merged 3 commits intoDefinitelyTyped:masterfrom
angelmerino:master
Apr 9, 2018
Merged

Add types for dnssd#24760
mhegazy merged 3 commits intoDefinitelyTyped:masterfrom
angelmerino:master

Conversation

@angelmerino
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • [ x ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x ] Test the change in your own code. (Compile and run.)
  • [ x ] Add or edit tests to reflect the change. (Run with npm test.)
  • [ x ] Follow the advice from the readme.
  • [ x ] Avoid common mistakes.
  • [ x ] Run npm run lint package-name (or tsc if no tslint.json is present).

Adding a new definition:

  • [ x ] The package does not provide its own types, and you can not add them.
  • [ x ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [ x ] Create it with dts-gen --dt, not by basing it on an existing project.
  • [ x ] tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

dnssd package in https://www.npmjs.com/package/dnssd

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 6, 2018

@angelmerino Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels Apr 6, 2018
@@ -0,0 +1,79 @@
{
"extends": "dtslint/dt.json",
"rules": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of having this many rules disabled for a new definition.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Apr 6, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

@angelmerino One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@typescript-bot typescript-bot removed the Revision needed This PR needs code changes before it can be merged. label Apr 9, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @paulvanbrenk - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@mhegazy mhegazy merged commit ad0637b into DefinitelyTyped:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants