Skip to content

(react-native) Adds SectionList scrollToLocation#25050

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
iRoachie:rn-scrollToLocation
Apr 17, 2018
Merged

(react-native) Adds SectionList scrollToLocation#25050
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
iRoachie:rn-scrollToLocation

Conversation

@iRoachie
Copy link
Copy Markdown
Contributor

@iRoachie iRoachie commented Apr 17, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

Fixes #25025

@iRoachie iRoachie requested a review from alloy as a code owner April 17, 2018 03:36
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Apr 17, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 17, 2018 •
edited
Loading

@iRoachie Thank you for submitting this PR!

🔔 @alloy @huhuanming @timwangdev @kamal @nelyousfi @alexdunne @swissmanu @bm-software - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 17, 2018

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit e460cfa into DefinitelyTyped:master Apr 17, 2018
@iRoachie iRoachie deleted the rn-scrollToLocation branch April 17, 2018 15:48
@iRoachie iRoachie mentioned this pull request May 3, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alloy alloy Awaiting requested review from alloy

1 more reviewer

@timwangdev timwangdev timwangdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author is Owner The author of this PR is a listed owner of the package. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iRoachie @typescript-bot @timwangdev @RyanCavanaugh