Skip to content

ember-data: Fix DS.Model.belongsTo and DS.Model.hasMany types#25072

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
aaxelb:fix-hasmany-belongsto
Apr 18, 2018
Merged

ember-data: Fix DS.Model.belongsTo and DS.Model.hasMany types#25072
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
aaxelb:fix-hasmany-belongsto

Conversation

@aaxelb
Copy link
Copy Markdown
Contributor

@aaxelb aaxelb commented Apr 17, 2018

Fix an error stemming from too many things named belongsTo and hasMany. The ones on DS.Model currently expect the name of a model (like DS.belongsTo does), but it should expect the name of a relationship (like DS.Snapshot.belongsTo does).


Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 17, 2018

@aaxelb Thank you for submitting this PR!

🔔 @dwickern @mike-north @chriskrycho - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Copy Markdown
Contributor

@dwickern dwickern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding tests!

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 17, 2018

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Apr 18, 2018
@RyanCavanaugh RyanCavanaugh merged commit 16c3ba2 into DefinitelyTyped:master Apr 18, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants