ember-data: Fix DS.Model.belongsTo and DS.Model.hasMany types#25072
Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom Apr 18, 2018
Merged
ember-data: Fix DS.Model.belongsTo and DS.Model.hasMany types#25072RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
@aaxelb Thank you for submitting this PR! 🔔 @dwickern @mike-north @chriskrycho - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
dwickern
approved these changes
Apr 17, 2018
Contributor
dwickern
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding tests!
Contributor
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
Member
|
🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ Congratulations on your first DefinitelyTyped contribution! 🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an error stemming from too many things named
belongsToandhasMany. The ones onDS.Modelcurrently expect the name of a model (likeDS.belongsTodoes), but it should expect the name of a relationship (likeDS.Snapshot.belongsTodoes).Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
https://www.emberjs.com/api/ember-data/3.0/classes/DS.Model/methods/hasMany?anchor=hasMany
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.