Skip to content

[Three] Added missing methods in Transform Controls#24819

Merged
mhegazy merged 2 commits intoDefinitelyTyped:masterfrom
stefan-lacatus:master
Apr 9, 2018
Merged

[Three] Added missing methods in Transform Controls#24819
mhegazy merged 2 commits intoDefinitelyTyped:masterfrom
stefan-lacatus:master

Conversation

@stefan-lacatus
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • [X ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [X ] Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • [X ] Follow the advice from the readme.
  • [X ] Avoid common mistakes.
  • [ X] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

Added missing isMesh prop
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 8, 2018

@stefan-lacatus Thank you for submitting this PR!

🔔 @gyohk @florentpoujol @SereznoKot @omni360 @ivoisbelongtous @piranha771 @qszhusightp @nakakura @s093294 @Pro @efokschaner @PsychoSTS @dhritzkiv @apurvaojas - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

drawMode: TrianglesDrawModes;
morphTargetInfluences?: number[];
morphTargetDictionary?: { [key: string]: number; };
isMesh: boolean;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to be part of the PR? It might be better to add it in a separate PR

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that the indentation is off here.

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@mhegazy mhegazy merged commit 882c7f3 into DefinitelyTyped:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants