Skip to content

[Three] Added missing methods in Transform Controls #24819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 2 commits into from
Apr 9, 2018
Merged

[Three] Added missing methods in Transform Controls #24819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b524692
Update three-transformcontrols.d.ts
stefan-lacatus Apr 8, 2018
9d7ba0a
Update three-core.d.ts
stefan-lacatus Apr 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions types/three/three-core.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5110,6 +5110,7 @@ export class Mesh extends Object3D {
drawMode: TrianglesDrawModes;
morphTargetInfluences?: number[];
morphTargetDictionary?: { [key: string]: number; };
isMesh: boolean;
Copy link
Copy Markdown
Contributor

@dhritzkiv dhritzkiv Apr 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to be part of the PR? It might be better to add it in a separate PR

Copy link
Copy Markdown
Contributor

@efokschaner efokschaner Apr 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that the indentation is off here.


setDrawMode(drawMode: TrianglesDrawModes): void;
updateMorphTargets(): void;
Expand Down
8 changes: 8 additions & 0 deletions types/three/three-transformcontrols.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import { Camera, Object3D } from "./three-core";

export class TransformControls extends Object3D {
constructor(object: Camera, domElement?: HTMLElement);

size: number;

space: string;

object: Object3D;

Expand All @@ -20,5 +24,9 @@ export class TransformControls extends Object3D {
setSize(size: number): void;

setSpace(space: string): void;

setTranslationSnap(size: number): void;

setRotationSnap(size: number): void;

}