Skip to content

Enhance definition for heapdump#24927

Merged
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
atd-schubert:enhance-heapdump-definition
Apr 17, 2018
Merged

Enhance definition for heapdump#24927
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
atd-schubert:enhance-heapdump-definition

Conversation

@atd-schubert
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: source-code and usage section of the README.md
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

See also #23891:

According to the source-code of heapdump the error is of type Error | null.

In addition, according to the usage section of the README.md there is also the possibility to call the function without a filename.


Closes #23891

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 11, 2018

@atd-schubert Thank you for submitting this PR!

🔔 @weekens - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Apr 16, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@RyanCavanaugh RyanCavanaugh merged commit ed43fdd into DefinitelyTyped:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants