Skip to content

Enhance definition for heapdump #24927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RyanCavanaugh merged 2 commits into from
Apr 17, 2018
Merged

Enhance definition for heapdump #24927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bfb59f
Enhance definition and according tests for heapdump
atd-schubert Apr 11, 2018
47548cd
Add changes to fix the CI
atd-schubert Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions types/heapdump/heapdump-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
import * as heapdump from 'heapdump';

heapdump.writeSnapshot('/tmp/myDump', (err) => {
if (err) {
console.log('Failed to dump heap: ' + err);
} else {
console.log('Successfully dumped heap!');
}
let strValue = "";
let errValue = new Error(strValue);
let nullValue = null;
let undefinedValue;

heapdump.writeSnapshot(strValue, (err, filename) => {
errValue = err as Error;
nullValue = err as null;
strValue = filename as string;
undefinedValue = filename as undefined;
});

heapdump.writeSnapshot((err, filename) => {
errValue = err as Error;
nullValue = err as null;
strValue = filename as string;
undefinedValue = filename as undefined;
});
4 changes: 3 additions & 1 deletion types/heapdump/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,7 @@
// Project: https://github.com/bnoordhuis/node-heapdump
// Definitions by: weekens <https://github.com/weekens>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 2.1

export function writeSnapshot(dumpFileName: string, callback: (err?: Error) => void): void;
export function writeSnapshot(dumpFileName?: string, callback?: (err: Error | null, filename: string | undefined) => void): void;
export function writeSnapshot(callback: (err: Error | null, filename: string | undefined) => void): void;