Skip to content

Update types for dnssd#25054

Merged
RyanCavanaugh merged 7 commits intoDefinitelyTyped:masterfrom
angelmerino:master
Apr 17, 2018
Merged

Update types for dnssd#25054
RyanCavanaugh merged 7 commits intoDefinitelyTyped:masterfrom
angelmerino:master

Conversation

@angelmerino
Copy link
Copy Markdown
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@angelmerino merge changes from @svogl: Service class added as returned in serviceUp/-changed callbacks; let Browser extend EventEmitter

amerino and others added 7 commits April 6, 2018 10:43
Browser implements EventEmitter
Service class added as returned in serviceUp/-changed callbacks; let Browser extend EventEmitter
@typescript-bot typescript-bot added Unowned This PR touches a package that doesn't have any listed owners. Author is Owner The author of this PR is a listed owner of the package. labels Apr 17, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 17, 2018

@angelmerino Thank you for submitting this PR!

Because this PR doesn't have any code reveiwers, a DefinitelyTyped maintainer will be reviewing it in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@RyanCavanaugh RyanCavanaugh merged commit df22c65 into DefinitelyTyped:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Unowned This PR touches a package that doesn't have any listed owners.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants