Skip to content

Service class added as returned in serviceUp/-changed callbacks; let Browser extend EventEmitter#1

Merged
angelmerino merged 2 commits intoangelmerino:masterfrom
svogl:master
Apr 17, 2018
Merged

Service class added as returned in serviceUp/-changed callbacks; let Browser extend EventEmitter#1
angelmerino merged 2 commits intoangelmerino:masterfrom
svogl:master

Conversation

@svogl
Copy link
Copy Markdown

@svogl svogl commented Apr 16, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://www.npmjs.com/package/dnssd
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

svogl added 2 commits April 16, 2018 09:09
Browser implements EventEmitter
@angelmerino angelmerino merged commit e095cbd into angelmerino:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants