Skip to content

react-virtualized: Allow null tabIndex#24777

Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
nsmaciej:react-virtualized-null-tab-index
Apr 9, 2018
Merged

react-virtualized: Allow null tabIndex#24777
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
nsmaciej:react-virtualized-null-tab-index

Conversation

@nsmaciej
Copy link
Copy Markdown
Contributor

@nsmaciej nsmaciej commented Apr 6, 2018

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes: tabIndex defaults to 0, not null bvaughn/react-virtualized#343
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 6, 2018

@mgoszcz2 Thank you for submitting this PR!

🔔 @kaoDev @guntherjh @wasd171 @szabolcsx @kraenhansen - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Copy Markdown
Contributor

@kaoDev kaoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@mhegazy mhegazy merged commit 7fa673a into DefinitelyTyped:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants