Skip to content

react-virtualized: Allow null tabIndex #24777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 1 commit into from
Apr 9, 2018
Merged

react-virtualized: Allow null tabIndex #24777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/react-virtualized/dist/es/Grid.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ export type GridCoreProps = {
/** Optional inline style */
style?: React.CSSProperties;
/** Tab index for focus */
tabIndex?: number;
tabIndex?: number | null;
/**
* Width of Grid; this property determines the number of visible (vs virtualized) columns.
*/
Expand Down
2 changes: 1 addition & 1 deletion types/react-virtualized/dist/es/List.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export type ListProps = GridCoreProps & {
/** Optional inline style */
style?: React.CSSProperties;
/** Tab index for focus */
tabIndex?: number;
tabIndex?: number | null;
/** Width of list */
width: number;
}
Expand Down
2 changes: 1 addition & 1 deletion types/react-virtualized/dist/es/Masonry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export type MasonryProps = {
scrollingResetTimeInterval?: number,
scrollTop?: number,
style?: React.CSSProperties,
tabIndex?: number,
tabIndex?: number | null,
width: number,
/**
* PLEASE NOTE
Expand Down
2 changes: 1 addition & 1 deletion types/react-virtualized/dist/es/Table.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ export type TableProps = GridCoreProps & {
/** Optional inline style */
style?: React.CSSProperties;
/** Tab index for focus */
tabIndex?: number;
tabIndex?: number | null;
/** Width of list */
width?: number;
}
Expand Down
1 change: 1 addition & 0 deletions types/react-virtualized/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// Szőke Szabolcs <https://github.com/szabolcsx>
// Kræn Hansen <https://github.com/kraenhansen>
// Steve Zhang <https://github.com/Stevearzh>
// Maciej Goszczycki <https://github.com/mgoszcz2>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
// TypeScript Version: 2.6

Expand Down