[aws-lambda] Rutime node8.10 support.#24823
Conversation
Bump version to 8.10 to match current runtime, allow returning result promises in handlers.
|
@simonbuchan Thank you for submitting this PR! 🔔 @skarum @tobyhede @buggy @y13i @wwwy3y3 @OrthoDex @MichaelMarner @daniel-cottone @kostya-misura @coderbyheart @palmithor @daniloraisi @Haydabase - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
If the maintainer has any opinion on if environment packages like this should have a versioned dependency on |
Bump version to 8.10 to match current runtime, allow returning result promises in handlers.
There is a tiny paragraph in the documentation describing this new feature, but it is much better described in the blog post announcing it
There is a type-breaking change that should be rare for most users, where previously valid
asynchandlers returning void would be accepted (and their results ignored), I chose to keep this rather than, e.g. also allowingPromise<void>as experimentation shows if the async function returns before the callback is invoked the lambda runtime will return anullvalue, and it is all too easy to do so. Because of this I chose to (finally!) set the type package version to the runtime version - but I would be happy to back this out if others think it's a minor enough break that needing a package.json update is unnecessary.Not sure if this should change to referencing/depending on node typings specifically at v8 as well - I think that would cause most users lots of type conflicts right now, but longer term it could catch people using node APIs their runtime doesn't have? If that's happening it should probably happen now so the breaking change can ride the major version bump.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.