@types/snekfetch: Added optional Snekfetch.SnekfetchOptions#24754
@types/snekfetch: Added optional Snekfetch.SnekfetchOptions#24754RyanCavanaugh merged 5 commits intoDefinitelyTyped:masterfrom ShayBox:patch-3
Conversation
|
Fixes #24752 |
|
@ShayBox Thank you for submitting this PR! 🔔 @DARKERtv - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@ShayBox The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
|
@Dev-Yukine are you OK being added to the authors list here? |
|
Yes in fine with this :) i told @ShayBox to add that since he already made a pr to Snekfetch typings (my addition) |
|
🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ Congratulations on your first DefinitelyTyped contribution! 🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ |
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
dts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.If removing a declaration:
notNeededPackages.json.