Skip to content

@types/snekfetch: Added optional Snekfetch.SnekfetchOptions#24754

Merged
RyanCavanaugh merged 5 commits intoDefinitelyTyped:masterfrom
ShayBox:patch-3
Apr 17, 2018
Merged

@types/snekfetch: Added optional Snekfetch.SnekfetchOptions#24754
RyanCavanaugh merged 5 commits intoDefinitelyTyped:masterfrom
ShayBox:patch-3

Conversation

@ShayBox
Copy link
Copy Markdown
Contributor

@ShayBox ShayBox commented Apr 6, 2018

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <https://snekfetch.js.org/?api=snekfetch>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@ShayBox
Copy link
Copy Markdown
Contributor Author

ShayBox commented Apr 6, 2018

Fixes #24752

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 6, 2018

@ShayBox Thank you for submitting this PR!

🔔 @DARKERtv - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

@ShayBox The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added Unmerged The author did not merge the PR when it was ready. and removed The Travis CI build failed labels Apr 10, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@RyanCavanaugh
Copy link
Copy Markdown
Member

@Dev-Yukine are you OK being added to the authors list here?

@DevYukine
Copy link
Copy Markdown
Contributor

DevYukine commented Apr 17, 2018

Yes in fine with this :) i told @ShayBox to add that since he already made a pr to Snekfetch typings (my addition)

@RyanCavanaugh RyanCavanaugh merged commit 0b0483c into DefinitelyTyped:master Apr 17, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants