Skip to content

dotenv-webpack: create definitions#24828

Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
karol-majewski:dotenv-webpack
Apr 9, 2018
Merged

dotenv-webpack: create definitions#24828
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
karol-majewski:dotenv-webpack

Conversation

@karol-majewski
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Apr 9, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 9, 2018

@karol-majewski Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Apr 9, 2018
@mhegazy mhegazy merged commit 6bd12e9 into DefinitelyTyped:master Apr 9, 2018
@karol-majewski karol-majewski deleted the dotenv-webpack branch April 9, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package. Other Approved This PR was reviewed and signed-off by a community member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants