Skip to content

radium: update typings to fit with new default export in radium >= 0.22.0#24686

Merged
mhegazy merged 3 commits intoDefinitelyTyped:masterfrom
Q-Man:master
Apr 9, 2018
Merged

radium: update typings to fit with new default export in radium >= 0.22.0#24686
mhegazy merged 3 commits intoDefinitelyTyped:masterfrom
Q-Man:master

Conversation

@Q-Man
Copy link
Copy Markdown
Contributor

@Q-Man Q-Man commented Apr 3, 2018

From radium >= 0.22.0 the export has changed to default export.
See 0.22.0 here: https://github.com/FormidableLabs/radium/blob/master/CHANGELOG.md

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 3, 2018

@Q-Man Thank you for submitting this PR!

🔔 @alexgorbatchev @nupplaphil @asvetliakov @mihe - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

Copy link
Copy Markdown
Contributor

@paulvanbrenk paulvanbrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the tabs back to spaces, please.

@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Merge:Express labels Apr 3, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

@Q-Man One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@Q-Man
Copy link
Copy Markdown
Contributor Author

Q-Man commented Apr 9, 2018

This was a mistake, tabs were automatically changed by my IDE. I changed the tabs back to spaces.

@typescript-bot typescript-bot added Merge:Express and removed Revision needed This PR needs code changes before it can be merged. labels Apr 9, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @paulvanbrenk - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@mhegazy mhegazy merged commit e2efee7 into DefinitelyTyped:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants