Merged
Conversation
Contributor
|
@AndersonFriaca Thank you for submitting this PR! Because this PR doesn't have any code reveiwers, a DefinitelyTyped maintainer will be reviewing it in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
andnp
reviewed
Apr 5, 2018
types/jquery-countto/index.d.ts
Outdated
| * A handler that is used to format the current value before rendering to the DOM | ||
| */ | ||
| formatter: (value: number, options: Options) => string; | ||
| formatter?: (value: number, options: Options) => string; |
Contributor
There was a problem hiding this comment.
Nit: Maybe worth changing this whole interface to:
export type Options = Partial<{
from: number,
to: number,
speed: number,
...
}>;so that future maintainers don't need to remember to add ? to the keys?
Contributor
Author
There was a problem hiding this comment.
Great idea, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
https://github.com/mhuggins/jquery-countTo/blob/91fff4b6166397d03a06743755c7656650f6f8d9/jquery.countTo.js#L25
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.