Skip to content

Ember: Make RegistryProxyMixin.register options optional.#25076

Merged
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
chriskrycho:ember-registry-proxy-register
Apr 18, 2018
Merged

Ember: Make RegistryProxyMixin.register options optional.#25076
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
chriskrycho:ember-registry-proxy-register

Conversation

@chriskrycho
Copy link
Copy Markdown
Contributor

@chriskrycho chriskrycho commented Apr 17, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

Copy link
Copy Markdown
Contributor

@dwickern dwickern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this seems to match what I found on emberobserver code search

@typescript-bot typescript-bot added Author Approved Author is Owner The author of this PR is a listed owner of the package. labels Apr 17, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 17, 2018

@chriskrycho Thank you for submitting this PR!

🔔 @jedmao @bttf @dwickern @theroncross @mfeckie @alexlafroscia - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 17, 2018

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Apr 18, 2018
@RyanCavanaugh RyanCavanaugh merged commit cfa60b7 into DefinitelyTyped:master Apr 18, 2018
@chriskrycho chriskrycho deleted the ember-registry-proxy-register branch January 16, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants