Skip to content

Fix JsonSchema.type definition in tv4#25020

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
moqada:tv4
Apr 17, 2018
Merged

Fix JsonSchema.type definition in tv4#25020
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
moqada:tv4

Conversation

@moqada
Copy link
Copy Markdown
Contributor

@moqada moqada commented Apr 16, 2018

JsonSchema.type properties have not allowed an array of string now. type properties should receive a string and array of a string by a spec of JSON Schema.

https://github.com/json-schema-org/json-schema-spec/blob/master/schema.json#L151-L161

Test cases of tv4 contain an array of string in type properties.

https://github.com/geraintluff/tv4/blob/master/test/tests/01%20-%20Any%20types/01%20-%20type.js#L10-L22


Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018

@moqada Thank you for submitting this PR!

🔔 @Bartvds @psnider - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Copy Markdown
Contributor

@psnider psnider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit bb51a7b into DefinitelyTyped:master Apr 17, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants