Skip to content

update#1

Merged
heroboy merged 48 commits intoheroboy:masterfrom
DefinitelyTyped:master
Apr 17, 2018
Merged

update#1
heroboy merged 48 commits intoheroboy:masterfrom
DefinitelyTyped:master

Conversation

@heroboy
Copy link
Copy Markdown
Owner

@heroboy heroboy commented Apr 17, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

dylanscott and others added 30 commits April 14, 2018 12:08
* Re-type `helper` from @ember/component/helper

Previous typing caused an error about using private name `Ember.Helper`
when generating declaration files.

Fortunately, the previous typings were incorrect anyway, so we can
remove the reference to `Ember.Helper` and thus fix the issue.

Relevant links:
* microsoft/TypeScript#5711
* microsoft/TypeScript#6307
* https://www.emberjs.com/api/ember/2.18/functions/@ember%2Fcomponent%2Fhelper/helper
* https://github.com/emberjs/ember.js/blob/v2.18.2/packages/ember-glimmer/lib/helper.ts#L120

* Add test for `helper` from @ember/component/helper
* Add 2 missing functions in office-js

* More details about API set of added functions
…s dynamically (#24824)

* Add the missing typings required by @howtimeflies/ngx-highcharts

* Add tests for the new added typings.
* Add types for express-ws

* strictFunctionTypes=true

* dtslint compliant

* union types for application and router

* allow https server

* applyTo accepts object

* fix lint error

* applyTo accepts router-like obj

* websocket method returns this
* provide easy access to interface

* declare is not needed
#24953)

* typings update to catch up with current version of react-virtualized

* fixed lint errors

* fixed ts version

* fixed void return type of defaultProps functions

* changed interface to type for better consistency

* fixed signature of onChildScroll params in WindowScroller

* Auto stash before merge of "enable-strict-mode" and "master"

* removed unimportant line from test file

* replaced strict with explicit options

* updated TS version

* ts version set to 2.7

* back to ts 2.6

* changed autogenerated relative import to global import
* d3-geo strictNullChecks mode:
Allow GeoGeometryObjects type to be null
Check existence of optional mehtods before calling them
Added null to union type or some results of call

* Missing space

* Min TS 2.4 for d3-geo

* Back to TS 2.3

* Added null as acceptable type

* d3-geo : Use of default generic types

* d3-geo : Removed generic type when using default

* d3-geo : fix generic types

* d3-geo : tests with nullable features
* lodash: _.get should with numeric keys, too.
Also added some better tests.

* lodash: add one more NumericDictionary overload for _.get

* lodash: more reasonable index for _.get tests

* lodash: support placeholders for curry

* lodash: add logic for generating overloads with placeholders

* lodash: fix placeholder generation bugs

* lodash: use the original parameter name for placeholder parameters

* lodash: stop generating unnecessary generics

* lodash: move all FP functions into a single file.
Trying to fix memory error in tests.

* lodash: omit comments and useless overloads to make the build work

* lodash: update fp function files

* Fix placeholder definition files

* lodash: add placeholder constants to fp definitions

* lodash: looks like we missed some jsdoc comments.
Let's omit them for consistency.

* lodash: fix build errors
* Add new RenderProps-style Context from React 16.3

React 16.3 has a new recommended API for Context, with new Context, Provider, and Consumer typings.

* Add overload for createContext() to be called with no arguments

* Fix syntax

* Refactor out Props for Consumer & Provider
…content. (#24910)

* Updated the typings to allow JSX elements in addition to strings for the toast message content.
Refer to https://tomchentw.github.io/react-toastr/

* Update version number of react-toastr type definition.

* Revert version number to match toastr's version number
Change toast notify functions to use string or ReactNode types explicitly
Revert change to options override type

* ReactNode includes string.
* Add missing prop to Screen

* Use new prop in tests
…maps (#25017)

* Adding draggable property to AbstractMarker in heremaps

* Fix jsdoc and optional for draggable property to AbstractMarker in heremaps

* Fix jsdoc description for draggable property to AbstractMarker in heremaps
…r to match source package (#25026)

* renamed exported class from OAuth2Verifier to Verifier to match export in @feathersjs/authentication-oauth2 package

* fixed linting
Fix Publisher#publish signature, so that it returns a promise 
to messageId (string): https://cloud.google.com/nodejs/docs/reference/pubsub/0.18.x/Publisher#publish
* fix bugs with types

* fixed type errors

* more type errors fixed

* fixed errors and added missing type definitions

* fix all typos and added all missing ones

* change inappropriate names

* Updated names to be more accurate.

* adds EnumDWT_ConvertMode to make compatible with the old enum

* Remove type for sync use of ConvertToBase64 which isn't supported for now

* adding new line at the end
jamescdavis and others added 18 commits April 16, 2018 15:24
* add missing property for ReduxLoggerOptions

add titleFormatter property type definition for ReduxLoggerOptions

* fix ci error

fix no-trailing-whitespace error
add `optionalTarget` parameter
* Add definitions for transports

* Fix transport option. Add tests.

* Bump version

* Fix linting error
* Add muri types.

* Resolve linting issues.

* Remove unnecessary TypeScript version specification.
* added schema-registry types

* added few more tests

* cleaned

* removed declare module
* Added typings for network-interfaces

* Added typings for network-interfaces

* Corrected build errors
* Add type defintions for the is-ci package

* Apply settings from generator

* Merge changes from generator

* Set strictFunctionChecks to true
* Add type definitions for react-router-param-link.

* Declare TypeScript version.
* [ADD] Wix Detox Types

* [FIX] Detox Definiations lint error

* [FIX] Lint issues
- Move typings for v3 to the separate v3 folder
 - Implement typings for v4.2
 - Implement tests for typings
* Enhance definition and according tests for heapdump

* Add changes to fix the CI
* Declare that `CKEDITOR` has event subscription interface for global events like `"instanceCreated"`.

Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR.html#Events

* Declare `CKEDITOR.editor.getSelectedHtml` with overloads.

Documentation link: https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.editor-method-getSelectedHtml

* Declare some arguments as optional

Documentation links:

* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.event-method-preventDefault
* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.range-method-createBookmark2
* https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_dom_node.html#method-getAddress
* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.range-method-getCommonAncestor

* Fix typings of `createBookmark[s][2]`:

* Properly declare methods `createBookmarks[2]` instead of `createBookmark[2]` on `CKEDITOR.dom.rangeList`.

Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_dom_rangeList.html#method-createBookmarks

* Use return type of `bookmark[]` for "intrusive bookmarks" everywhere as in `CKEDITOR.dom.range.createBookmark`.

* Declare parameters of `CKEDITOR.dom.selection.createBoomarks[2]` as required `Object`'s to follow the documentation.

Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_dom_selection.html#method-createBookmarks

* Declare method `CKEDITOR.dom.node.remove` mistakenly named `move` in the typings.

* Declare `CKEDITOR.dom.range.setEnd{Before,After}` in addition to `setStart{Before,After}`.

Documentation links:

* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.range-method-setEndAfter
* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.dom.range-method-setEndBefore

* Declare some `CKEDITOR.tools`

Documentation links:

* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.tools-method-copy
* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.tools-method-isArray
* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.tools-method-override
* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.tools-method-prototypedCopy

* Declare `CKEDITOR.plugins.registered`.

Documentation link: https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.resourceManager-property-registered

* Declare `CKEDITOR.htmlParser.element.addClass` in addition to `removeClass` and `hasClass`.

Documentation link: https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.htmlParser.element-method-addClass

* Declare `CKEDITOR.htmlParser.{element,fragment}.forEach`.

Documentation links:

* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.htmlParser.element-method-forEach
* https://docs.ckeditor.com/ckeditor4/docs/#!/api/CKEDITOR.htmlParser.fragment-method-forEach

* Coding style: Convert to single quotes and spaces for indentation.

* Make `fileName` parameter of `CKEDITOR.plugins.addExternal` optional.

Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_plugins.html#method-addExternal

* Make `editable` as a class and declare its constructor.

Documentation link: https://docs.ckeditor.com/ckeditor4/latest/api/CKEDITOR_editable.html#method-constructor
…HyperCubeContinuousData (#25010)

Signed-off-by: Konrad Mattheis <konrad.mattheis@akquinet.de>
@heroboy heroboy merged commit d31c468 into heroboy:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.