Skip to content

Topojson: extract topojson-client, topojson-simplify, topojson-specification#24992

Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
denisname:topojson-split
Apr 14, 2018
Merged

Topojson: extract topojson-client, topojson-simplify, topojson-specification#24992
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
denisname:topojson-split

Conversation

@denisname
Copy link
Copy Markdown
Contributor

Topojson regroup several libraries (topojson, topojson-server, topojson-simplify, topojson-client, topojson-specification). The actual typing definition contain them all making it immpossible to use them separately (#24941). This PR extract topojson-client, topojson-simplify and topojson-specification in their own type definition.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Apr 14, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 14, 2018

@denisname Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@mhegazy mhegazy merged commit ee7e979 into DefinitelyTyped:master Apr 14, 2018
@denisname denisname deleted the topojson-split branch June 30, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package. New Definition This PR creates a new definition package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants