Add 2 missing functions in office-js#24924
Conversation
|
@amelieturgeon Thank you for submitting this PR! 🔔 @OfficeDev @LanceEa @Zlatkovsky @kbrandl @Rick-Kirkham - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Zlatkovsky
left a comment
There was a problem hiding this comment.
Thanks for submitting the PR! Looks great, just added one small comment, if you don't mind fixing it.
types/office-js/index.d.ts
Outdated
| getSelectedEntities(): Entities; | ||
| /** | ||
| * Returns string values in the currently selected message object that match the regular expressions defined in the manifest XML file and | ||
| * are selected in the current item (1.6 and up) |
There was a problem hiding this comment.
Both for this comment and the other one, could you expand the "1.6" text to clarify the requirement set that it's associated with? E.g., Minimum requirement set: Mailbox 1.6
|
@annich-MS , FYI re. an Outlook d.ts change |
|
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
Perfect, thanks! @DefinitelyTyped team, please merge in. |
Please fill in this template.
npm test.) [there was no test for Outlook]npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. [not making substantial changes]