Skip to content

Remove react-native-collapsible#25011

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
iRoachie:remove-react-native-collapsible
Apr 16, 2018
Merged

Remove react-native-collapsible#25011
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
iRoachie:remove-react-native-collapsible

Conversation

@iRoachie
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If removing a declaration:

  • Delete the package's directory.
  • Add it to notNeededPackages.json.

I'm the maintainer over at react-native-collapsible, so moving the types over there.

@iRoachie
Copy link
Copy Markdown
Contributor Author

@alloy

@typescript-bot typescript-bot added Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Apr 15, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 15, 2018

@iRoachie Thank you for submitting this PR!

🔔 @umidbekkarimov - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit 3d822ec into DefinitelyTyped:master Apr 16, 2018
@iRoachie iRoachie deleted the remove-react-native-collapsible branch December 29, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants