Skip to content

fix for wrong method signature in params of WindowScroller render-prop#24953

Merged
mhegazy merged 14 commits intoDefinitelyTyped:masterfrom
kaoDev:enable-strict-mode
Apr 14, 2018
Merged

fix for wrong method signature in params of WindowScroller render-prop#24953
mhegazy merged 14 commits intoDefinitelyTyped:masterfrom
kaoDev:enable-strict-mode

Conversation

@kaoDev
Copy link
Copy Markdown
Contributor

@kaoDev kaoDev commented Apr 12, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 12, 2018

@kaoDev Thank you for submitting this PR!

🔔 @guntherjh @wasd171 @szabolcsx @kraenhansen @Stevearzh @mgoszcz2 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

@kaoDev The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author is Owner The author of this PR is a listed owner of the package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants