Skip to content

fix for wrong method signature in params of WindowScroller render-prop #24953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 14 commits into from
Apr 14, 2018
Merged

fix for wrong method signature in params of WindowScroller render-prop #24953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2471aff
typings update to catch up with current version of react-virtualized
Apr 11, 2018
038076c
fixed lint errors
Apr 11, 2018
6f33149
fixed ts version
Apr 11, 2018
1137562
fixed void return type of defaultProps functions
Apr 11, 2018
d65b750
changed interface to type for better consistency
Apr 11, 2018
9790a3d
fixed signature of onChildScroll params in WindowScroller
Apr 12, 2018
cd290d1
Merge branch 'master' into enable-strict-mode
Apr 12, 2018
36c4113
Auto stash before merge of "enable-strict-mode" and "master"
Apr 12, 2018
148a083
removed unimportant line from test file
Apr 12, 2018
685e4b7
replaced strict with explicit options
Apr 12, 2018
74a8560
updated TS version
Apr 12, 2018
861d1d2
ts version set to 2.7
Apr 12, 2018
d944b0e
back to ts 2.6
Apr 12, 2018
6d4ecc4
changed autogenerated relative import to global import
Apr 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions types/react-virtualized/dist/es/CellMeasurer.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ export class CellMeasurerCache implements CellMeasurerCacheInterface {
constructor(params?: CellMeasurerCacheParams);
clear(rowIndex: number, columnIndex: number): void;
clearAll(): void;
columnWidth: (params: { index: number }) => number | undefined;
columnWidth: (params: { index: number }) => number;
readonly defaultHeight: number;
readonly defaultWidth: number;
hasFixedHeight(): boolean;
hasFixedWidth(): boolean;
getHeight(rowIndex: number, columnIndex: number): number | undefined;
getWidth(rowIndex: number, columnIndex: number): number | undefined;
getHeight(rowIndex: number, columnIndex: number): number;
getWidth(rowIndex: number, columnIndex: number): number;
has(rowIndex: number, columnIndex: number): boolean;
rowHeight: (params: { index: number }) => number | undefined;
rowHeight: (params: { index: number }) => number;
set(
rowIndex: number,
columnIndex: number,
Expand Down
5 changes: 3 additions & 2 deletions types/react-virtualized/dist/es/Collection.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ export type CollectionCellGroupRenderer = (
) => React.ReactNode[];
export type CollectionCellRendererParams = {
index: number;
key: string;
style?: React.CSSProperties;
isScrolling: boolean;
key: number;
style: React.CSSProperties;
};
export type CollectionCellRenderer = (
params: CollectionCellRendererParams
Expand Down
7 changes: 1 addition & 6 deletions types/react-virtualized/dist/es/Grid.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,7 @@ export type ScrollParams = {
scrollTop: number;
scrollWidth: number;
};
export type SectionRenderedParams = {
columnStartIndex: number;
columnStopIndex: number;
rowStartIndex: number;
rowStopIndex: number;
};
export type SectionRenderedParams = RenderedSection;
export type SCROLL_DIRECTION_HORIZONTAL = "horizontal";
export type SCROLL_DIRECTION_VERTICAL = "vertical";
export type OverscanIndicesGetterParams = {
Expand Down
6 changes: 2 additions & 4 deletions types/react-virtualized/dist/es/Table.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,7 @@ export type TableProps = GridCoreProps & {
*/
autoHeight?: boolean;
/** One or more Columns describing the data displayed in this row */
children?:
| React.ReactElement<ColumnProps>[]
| React.ReactElement<ColumnProps>;
children?: React.ReactNode;
/** Optional CSS class name */
className?: string;
/** Disable rendering the header at all */
Expand Down Expand Up @@ -372,7 +370,7 @@ export const SortDirection: SortDirectionStatic;
export type SortDirectionType = "ASC" | "DESC";

export const SortIndicator: React.StatelessComponent<{
sortDirection: SortDirectionType;
sortDirection?: SortDirectionType;
}>;

/**
Expand Down
2 changes: 1 addition & 1 deletion types/react-virtualized/dist/es/WindowScroller.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export type WindowScrollerProps = {
*/
children: (
params: {
onChildScroll: ({ scrollTop: number }) => void;
onChildScroll: (params: { scrollTop: number }) => void;
registerChild: (params?: Element) => void;
height: number;
isScrolling: boolean;
Expand Down
3 changes: 2 additions & 1 deletion types/react-virtualized/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ export {
TableHeaderRowRenderer,
TableProps,
TableRowProps,
TableRowRenderer
TableRowRenderer,
SortParams
} from "./dist/es/Table";
export {
WindowScroller,
Expand Down
Loading