Skip to content

[react-motion] change TransitionPlainStyle key type to string#25003

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
mvasin:patch-1
Apr 16, 2018
Merged

[react-motion] change TransitionPlainStyle key type to string#25003
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
mvasin:patch-1

Conversation

@mvasin
Copy link
Copy Markdown
Contributor

@mvasin mvasin commented Apr 15, 2018

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Test the change in your own code. (Compile and run.)

If changing an existing definition:

I don't use TypeScript yet, that's why I didn't test my own code as the checklist suggests. I've noticed the type mismatch between Flow and TypeScript as I was figuring out the API of react-motion, and I guess it should be corrected.

@mvasin mvasin changed the title [google-map-react] change TransitionPlainStyle key type to string [react-motion] change TransitionPlainStyle key type to string Apr 15, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 15, 2018

@mvasin Thank you for submitting this PR!

🔔 @stepancar @asvetliakov @DimitarNestorov - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit 080eb8f into DefinitelyTyped:master Apr 16, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants