[@types/heremaps] Adding draggable property to AbstractMarker in heremaps#25017
[@types/heremaps] Adding draggable property to AbstractMarker in heremaps#25017RyanCavanaugh merged 3 commits intoDefinitelyTyped:masterfrom
Conversation
|
@fx88 Thank you for submitting this PR! 🔔 @Josh-ES @denyo - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Josh-ES
left a comment
There was a problem hiding this comment.
A few minor comments to address.
types/heremaps/index.d.ts
Outdated
| setIcon(icon: (H.map.Icon | H.map.DomIcon)): H.map.AbstractMarker; | ||
|
|
||
| /** | ||
| * This this property ensure that the marker can receive drag events |
There was a problem hiding this comment.
It would be nice if this could follow the JSDoc conventions elsewhere, but I'm not too bothered.
types/heremaps/index.d.ts
Outdated
| /** | ||
| * This this property ensure that the marker can receive drag events | ||
| */ | ||
| draggable: boolean; |
There was a problem hiding this comment.
Is this parameter meant to be optional?
|
@Josh-ES Hi, i have fixed your findings. Thanks for reviewing. |
|
@fx88 Is the property description supposed to start with |
|
@Josh-ES You are right! :-) I have fixed it.. |
|
Many thanks for bearing with me! Approving 👍 |
|
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ Congratulations on your first DefinitelyTyped contribution! 🌟 🎈 🎉 🏆 🎂 ✨ ⭐️ |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present, andtsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.If removing a declaration:
notNeededPackages.json.