Skip to content

[@types/heremaps] Adding draggable property to AbstractMarker in heremaps#25017

Merged
RyanCavanaugh merged 3 commits intoDefinitelyTyped:masterfrom
fx88:master
Apr 16, 2018
Merged

[@types/heremaps] Adding draggable property to AbstractMarker in heremaps#25017
RyanCavanaugh merged 3 commits intoDefinitelyTyped:masterfrom
fx88:master

Conversation

@fx88
Copy link
Copy Markdown
Contributor

@fx88 fx88 commented Apr 16, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018

@fx88 Thank you for submitting this PR!

🔔 @Josh-ES @denyo - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Copy Markdown
Contributor

@Josh-ES Josh-ES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments to address.

setIcon(icon: (H.map.Icon | H.map.DomIcon)): H.map.AbstractMarker;

/**
* This this property ensure that the marker can receive drag events
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this could follow the JSDoc conventions elsewhere, but I'm not too bothered.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

/**
* This this property ensure that the marker can receive drag events
*/
draggable: boolean;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this parameter meant to be optional?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@fx88
Copy link
Copy Markdown
Contributor Author

fx88 commented Apr 16, 2018

@Josh-ES Hi, i have fixed your findings. Thanks for reviewing.

@Josh-ES
Copy link
Copy Markdown
Contributor

Josh-ES commented Apr 16, 2018

@fx88 Is the property description supposed to start with This this as opposed to just This? I'm being really pedantic here, but that's the last little thing to think about

@fx88
Copy link
Copy Markdown
Contributor Author

fx88 commented Apr 16, 2018

@Josh-ES You are right! :-) I have fixed it..

@Josh-ES
Copy link
Copy Markdown
Contributor

Josh-ES commented Apr 16, 2018

Many thanks for bearing with me! Approving 👍

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit b74166a into DefinitelyTyped:master Apr 16, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants