Skip to content

[daterangepicker] Add missing isCustomDate into Settings type#25042

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
jacoporicare:daterangepicker/iscustomdate
Apr 16, 2018
Merged

[daterangepicker] Add missing isCustomDate into Settings type#25042
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
jacoporicare:daterangepicker/iscustomdate

Conversation

@jacoporicare
Copy link
Copy Markdown
Contributor

@jacoporicare jacoporicare commented Apr 16, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: http://www.daterangepicker.com/#options
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018 •
edited
Loading

@jacoporicare Thank you for submitting this PR!

🔔 @SirMartin @smasala @nertzy - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit b3cea7a into DefinitelyTyped:master Apr 16, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

RyanCavanaugh commented Apr 16, 2018

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

@jacoporicare
Copy link
Copy Markdown
Contributor Author

jacoporicare commented Apr 17, 2018

@RyanCavanaugh Thank you a lot! 🤝🥂 Actually my first contribution to OSS ever. 😊

@jacoporicare
Copy link
Copy Markdown
Contributor Author

jacoporicare commented Apr 20, 2018 •
edited
Loading

@RyanCavanaugh Hello Ryan, may I have a quick question - I fixed this typing because I'm using another typings: react-bootstrap-daterangepicker and it's using this typing as a base type. Do I have to do something (open a PR for example) so it's updated on NPM as well? Thank you!

@jacoporicare jacoporicare deleted the daterangepicker/iscustomdate branch April 20, 2018 07:02
@RyanCavanaugh
Copy link
Copy Markdown
Member

RyanCavanaugh commented Apr 20, 2018

@jacoporicare no, types are automatically published to NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@smasala smasala smasala approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacoporicare @typescript-bot @RyanCavanaugh @smasala