Skip to content

@feathersjs/authentication-oauth2 - renamed OAuth2Verifier to Verifier to match source package#25026

Merged
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
anishpateluk:master
Apr 16, 2018
Merged

@feathersjs/authentication-oauth2 - renamed OAuth2Verifier to Verifier to match source package#25026
RyanCavanaugh merged 2 commits intoDefinitelyTyped:masterfrom
anishpateluk:master

Conversation

@anishpateluk
Copy link
Copy Markdown
Contributor

The source package @feathersjs/authentication-oauth2 exports the class OAuth2Verifier as Verifier, please see the source.

This PR updates the exported class name to match the source.

…t in @feathersjs/authentication-oauth2 package
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018

@anishpateluk Thank you for submitting this PR!

🔔 @j2L4e - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

@anishpateluk The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

Copy link
Copy Markdown
Contributor

@j2L4e j2L4e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit af9cce1 into DefinitelyTyped:master Apr 16, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants