Skip to content

Expand BufferList.append(...) to allow BufferList, array, and string params#24844

Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
sehrope:bl-append-expand-acceptable-params
Apr 14, 2018
Merged

Expand BufferList.append(...) to allow BufferList, array, and string params#24844
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
sehrope:bl-append-expand-acceptable-params

Conversation

@sehrope
Copy link
Copy Markdown
Contributor

@sehrope sehrope commented Apr 9, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 9, 2018

@sehrope Thank you for submitting this PR!

🔔 @Bartvds - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Apr 14, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@mhegazy mhegazy merged commit 7132597 into DefinitelyTyped:master Apr 14, 2018
@sehrope
Copy link
Copy Markdown
Contributor Author

sehrope commented Apr 14, 2018

Sweet. Thanks @mhegazy.

@sehrope sehrope deleted the bl-append-expand-acceptable-params branch April 14, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants