Skip to content

Add type definition for is-ci#25016

Merged
RyanCavanaugh merged 4 commits intoDefinitelyTyped:masterfrom
atd-schubert:typings-for-is-ci
Apr 16, 2018
Merged

Add type definition for is-ci#25016
RyanCavanaugh merged 4 commits intoDefinitelyTyped:masterfrom
atd-schubert:typings-for-is-ci

Conversation

@atd-schubert
Copy link
Copy Markdown
Contributor

Adding a type definition for npm package is-ci.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

Type definition according to the documentation of the package taken from: https://github.com/watson/is-ci/blob/master/README.md

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels Apr 16, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018

@atd-schubert Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@RyanCavanaugh RyanCavanaugh merged commit 600f681 into DefinitelyTyped:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants