Skip to content

[Ramda] fixed tsnext type inference errors#24942

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
ProofOfKeags:bugfix/ramda-tsnext-inference-errors
Apr 16, 2018
Merged

[Ramda] fixed tsnext type inference errors#24942
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
ProofOfKeags:bugfix/ramda-tsnext-inference-errors

Conversation

@ProofOfKeags
Copy link
Copy Markdown
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:
N/A

Summary: This is a bugfix introduced by tsnext and the fact that the build only runs on the packages that are different. It is unclear when this bug was introduced. I discovered it in the process of doing #24936. That build will succeed upon merging this branch. I kept them separate for clarity's sake.

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Apr 12, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 12, 2018

@CaptJakk Thank you for submitting this PR!

🔔 @donnut @mdekrey @mrdziuban @sbking @afharo @teves-castro @1M0reBug @hojberg @charlespwd @samsonkeung @angeloocana @raynerd @googol @moshensky @ethanresnick @leighman - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit ed2cf92 into DefinitelyTyped:master Apr 16, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

@ProofOfKeags ProofOfKeags deleted the bugfix/ramda-tsnext-inference-errors branch April 17, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants