[lodash] Placeholder support#24728
Conversation
Also added some better tests.
Trying to fix memory error in tests.
Let's omit them for consistency.
|
@aj-r Thank you for submitting this PR! 🔔 @bczengel @chrootsu @stepancar @Ailrun @e-cloud @thorn0 @jtmthf @DomiR - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@aj-r The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
@Andy-MS This PR has been approved for 8 days. Can it be merged? The build error is lowdb, not lodash. |
|
Hi guys, Since this PR I can't include a single function from fp module : import * as flow from "lodash/fp/flow";When compiling I have now this issue : Error with |
|
@maximeag You should probably be using |
|
I realize this is an old change but does this effectively mean that |
fpfunctions (fixesplaceholderis missing fromlodash/fp#24602)"lodash/fp/placehoder"and the alias"lodash/fp/__"Unfortunately, since this required adding a ridiculous number of new overloads, it caused the tests to run out of memory. To fix the tests, I needed to do the following:
interface LodashPick { (): LodashPick; ... }). I don't see any use case for these overloads (they don't really do anything), so I removed them to free up some space.fpfunction definitions. This is unfortunate, but it made the biggest difference by far in the performance of the tests.fp.d.ts, instead of being distributed among hundreds of files. Unfortunately this change makes the diff very hard to read, but it's necessary in order to make the tests pass.So there are some drawbacks, but I think the value of placeholder support outweighs them all.
Template:
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.