Skip to content

[lodash] Placeholder support #24728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhegazy merged 20 commits into from
Apr 14, 2018
Merged

[lodash] Placeholder support #24728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
057754c
lodash: _.get should with numeric keys, too.
aj-r Dec 23, 2017
6e0532c
lodash: add one more NumericDictionary overload for _.get
aj-r Jan 2, 2018
5b606ca
lodash: more reasonable index for _.get tests
aj-r Jan 3, 2018
7336172
Merge with upstream
aj-r Jan 27, 2018
ea5f3ab
Merge branch 'master' of https://github.com/DefinitelyTyped/Definitel…
aj-r Feb 1, 2018
6182842
Merge branch 'master' of https://github.com/DefinitelyTyped/Definitel…
aj-r Feb 25, 2018
3776df2
Merge branch 'master' of https://github.com/DefinitelyTyped/Definitel…
aj-r Mar 3, 2018
80c7a68
Merge branch 'master' of https://github.com/DefinitelyTyped/Definitel…
aj-r Mar 23, 2018
9250ba1
lodash: support placeholders for curry
aj-r Mar 29, 2018
b0c7c3c
lodash: add logic for generating overloads with placeholders
aj-r Mar 30, 2018
b4219b2
lodash: fix placeholder generation bugs
aj-r Mar 31, 2018
ef0606b
lodash: use the original parameter name for placeholder parameters
aj-r Mar 31, 2018
fe51cfe
lodash: stop generating unnecessary generics
aj-r Mar 31, 2018
50630e7
lodash: move all FP functions into a single file.
aj-r Mar 31, 2018
5bb0c8b
lodash: omit comments and useless overloads to make the build work
aj-r Apr 1, 2018
ad7d535
lodash: update fp function files
aj-r Apr 1, 2018
e8b4435
Fix placeholder definition files
aj-r Apr 2, 2018
457e926
lodash: add placeholder constants to fp definitions
aj-r Apr 5, 2018
cf5e106
lodash: looks like we missed some jsdoc comments.
aj-r Apr 5, 2018
fce29ec
lodash: fix build errors
aj-r Apr 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions types/lodash/common/array.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1405,7 +1405,7 @@ declare module "../index" {
this: LoDashImplicitWrapper<List<T1> | null | undefined>,
values1: List<T2>,
values2: List<T3>,
...values: Array<List<T4> | Comparator2<T1, T2 | T3 | T4>>,
...values: Array<List<T4> | Comparator2<T1, T2 | T3 | T4>>
): LoDashImplicitWrapper<T1[]>;

/**
Expand Down Expand Up @@ -1444,7 +1444,7 @@ declare module "../index" {
this: LoDashExplicitWrapper<List<T1> | null | undefined>,
values1: List<T2>,
values2: List<T3>,
...values: Array<List<T4> | Comparator2<T1, T2 | T3 | T4>>,
...values: Array<List<T4> | Comparator2<T1, T2 | T3 | T4>>
): LoDashExplicitWrapper<T1[]>;

/**
Expand Down
332 changes: 219 additions & 113 deletions types/lodash/common/function.d.ts
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion types/lodash/common/object.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3217,7 +3217,7 @@ declare module "../index" {
* @param object The object to modify.
* @param path The path of the property to set.
* @param value The value to set.
* @parem customizer The function to customize assigned values.
* @param customizer The function to customize assigned values.
* @return Returns object.
*/
setWith<T extends object>(
Expand Down
4 changes: 2 additions & 2 deletions types/lodash/common/util.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,14 +1207,14 @@ declare module "../index" {
* @param context The context object.
* @return Returns a new lodash function.
*/
runInContext(context?: object): typeof _;
runInContext(context?: object): LoDashStatic;
}

interface LoDashImplicitWrapper<TValue> {
/**
* @see _.runInContext
*/
runInContext(): typeof _;
runInContext(): LoDashStatic;
}

// stubArray
Expand Down
Loading