Activate strict null check in d3-format#25015
Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom Apr 16, 2018
Merged
Activate strict null check in d3-format#25015RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
Contributor
|
@denisname Thank you for submitting this PR! 🔔 @tomwanzek @gustavderdrache @borisyankov - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Contributor
|
A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
9 tasks
Contributor
|
Thanks, @denisname & @gustavderdrache ! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows pull request #24305. Code changes here are exactly like last commit it that PR for d3-format. I will push changes for d3-axis
later todayonce this will be merged. As addingvalueOfin d3-format is required for d3-axisstrictFunctionTypes...With this, d3-format validated for
strictNullChecks,strictFunctionTypesand TS 2.3.Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }.