Skip to content

Activate strict null check in d3-format#25015

Merged
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
denisname:d3-format-null
Apr 16, 2018
Merged

Activate strict null check in d3-format#25015
RyanCavanaugh merged 1 commit intoDefinitelyTyped:masterfrom
denisname:d3-format-null

Conversation

@denisname
Copy link
Copy Markdown
Contributor

@denisname denisname commented Apr 16, 2018

This follows pull request #24305. Code changes here are exactly like last commit it that PR for d3-format. I will push changes for d3-axis later today once this will be merged. As adding valueOf in d3-format is required for d3-axis strictFunctionTypes...

With this, d3-format validated for strictNullChecks, strictFunctionTypes and TS 2.3.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018

@denisname Thank you for submitting this PR!

🔔 @tomwanzek @gustavderdrache @borisyankov - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Copy Markdown
Contributor

@gustavderdrache gustavderdrache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@typescript-bot
Copy link
Copy Markdown
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@RyanCavanaugh RyanCavanaugh merged commit b77a6a0 into DefinitelyTyped:master Apr 16, 2018
@tomwanzek
Copy link
Copy Markdown
Contributor

Thanks, @denisname & @gustavderdrache !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants