Skip to content

raven: Add definitions for transports#24918

Merged
RyanCavanaugh merged 4 commits intoDefinitelyTyped:masterfrom
cmaddalozzo:master
Apr 16, 2018
Merged

raven: Add definitions for transports#24918
RyanCavanaugh merged 4 commits intoDefinitelyTyped:masterfrom
cmaddalozzo:master

Conversation

@cmaddalozzo
Copy link
Copy Markdown
Contributor

The module exports transports so they should be defined in the types.

The client's transport is no longer a function but an object with a send method: https://github.com/getsentry/raven-node/blob/master/lib/client.js#L327

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/getsentry/raven-node/
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 11, 2018

@cmaddalozzo Thank you for submitting this PR!

🔔 @scttcper @1999 @shreyjain1994 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Apr 11, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 16, 2018

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added Author Approved and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Apr 16, 2018
@RyanCavanaugh RyanCavanaugh merged commit 57381ed into DefinitelyTyped:master Apr 16, 2018
@RyanCavanaugh
Copy link
Copy Markdown
Member

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Congratulations on your first DefinitelyTyped contribution!

🌟 🎈 🎉 🏆 🎂 ✨ ⭐️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants